Searches all subdirectories in the bin folder when compiling list of assemblies#31
Searches all subdirectories in the bin folder when compiling list of assemblies#31akousmata wants to merge 1 commit intodavidebbo:masterfrom
Conversation
…assemblies to load.
|
Does this help when packages are installed parallell to the bin-folder? Or does it only search subfolders to the bin-folder? |
|
I haven't built WebActivator in quite some years. If people feel this is important, we can get this change in, but I need to set things up to build this package again. |
|
To put this in context, I originally forked the code and made the change for a project at a firm I worked at 6 years ago where this was needed. It worked fine for our needs and so I PR'd. I don't use this library all that much anymore but for those that do, it might be helpful. Although, I would recommend upgrading to a more modern toolchain at this point. |
|
Thanks @akousmata for the extra context. I will leave this alone unless other active users are asking for this. Also, part of the challenge is that it targets Framework 4.0, which is no longer supported. When opening it in VS 2022, it wants to update it to 4.8, and I'm not sure what breaking effects that could have. The targeting pack for 4.0 is no longer available. From https://learn.microsoft.com/en-us/dotnet/framework/install/guide-for-developers: |
This partially addresses closed issue #21; there are likely better ways of handling this, but this would be a quick fix.